Bug 336 - in CardAnalyser - TioX is incorrectly recognized as a AirPlane
Summary: in CardAnalyser - TioX is incorrectly recognized as a AirPlane
Status: RESOLVED FIXED
Alias: None
Product: Group 8 (2019)
Classification: Unclassified
Component: Factory (show other bugs)
Version: Version1.0
Hardware: PC Mac OS
: --- normal
Assignee: CJQ
URL:
Depends on:
Blocks:
 
Reported: 2019-12-04 20:12 HKT by LXL
Modified: 2019-12-05 00:23 HKT (History)
1 user (show)

See Also:

Attachments
test screenshot (152.94 KB, image/png)
2019-12-04 20:12 HKT, LXL 		Details
XXXY bug solved screenshot (22.09 KB, image/png)
2019-12-04 23:48 HKT, CJQ 		Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description LXL 2019-12-04 20:12:17 HKT 
Created attachment 35 [details]
test screenshot

During the test of isAirplane() method of CardAnalyser, we test the cards pattern of 'AAAB' which is not an Airplane but a TioX. However, the function verified it as an Airplane incorrectly.

The screenshot of test script and result are shown in the attachment.

Expected Output: false

Actual Output: true
Comment 1 CJQ 2019-12-04 23:48:39 HKT 
Created attachment 38 [details]
XXXY bug solved screenshot

Bug "XXXY" card combination returns true when being tested in isAirPlain() has been solved
Comment 2 CJQ 2019-12-05 00:23:53 HKT 
A judgment instruction is added in isAirPlane() as below:

if(cards.size()==4 || cards.size()==5) return false;

The screenshot of correct testing is in Attachment 38 [details]. The actual output is false now.